Skip to content

docs(docs): fix TanStack start command sequence - #7912

Closed
tomdeabreucodes wants to merge 3 commits into
prisma:mainfrom
tomdeabreucodes:docs/tanstack-start-command-fix
Closed

docs(docs): fix TanStack start command sequence#7912
tomdeabreucodes wants to merge 3 commits into
prisma:mainfrom
tomdeabreucodes:docs/tanstack-start-command-fix

Conversation

@tomdeabreucodes

@tomdeabreucodes tomdeabreucodes commented May 21, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Fixes: #7911

Summary by CodeRabbit

  • Documentation
    • Reorganized Prisma database setup instructions in the TanStack Start framework guide to clarify the proper workflow sequence. Updates include explicit guidance on running database migrations, generating the Prisma Client, and executing database seeding operations in the correct order for initial project configuration.

Review Change Stack

@vercel

vercel Bot commented May 21, 2026

Copy link
Copy Markdown

@tomdeabreucodes is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e46eb57d-5b40-4475-9587-efa70572042a

📥 Commits

Reviewing files that changed from the base of the PR and between fc24837 and 816a6b2.

📒 Files selected for processing (1)
  • apps/docs/content/docs/guides/frameworks/tanstack-start.mdx

Walkthrough

This PR corrects procedural errors in the TanStack Start setup guide. The Prisma initialization sequence is reordered: database migrations now run before Prisma Client generation. The "Seed the database" section is relocated to appear as a distinct step following the client setup, preventing confusion with the migration phase.

Changes

Prisma Setup Instructions

Layer / File(s) Summary
Prisma setup command sequence and database seeding flow
apps/docs/content/docs/guides/frameworks/tanstack-start.mdx		 Step 2.2 now correctly specifies migrations first (npm run db:migrate --name init), then Prisma Client generation (npm run db:generate). Step 2.3 "Seed the database" is introduced as a separate subsection, moving the db:seed command to appear only under the proper seeding workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the main change: fixing the command sequence in the TanStack Start documentation guide.
Linked Issues check ✅ Passed The changes correctly address both issues: fixing the migration command formatting and repositioning the 'Seed the database' subheader as reported in #7911.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the TanStack Start guide command sequence per issue #7911; no extraneous modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ankur-arch ankur-arch mentioned this pull request Sep 16, 2026
Merged
@ankur-arch

ankur-arch commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for contributing, @tomdeabreucodes. You caught a real error in the command sequence. The TanStack Start guide has since moved to guides/v7/, which is why this branch conflicts, so I re-applied your fix there in #8283 with credit to you. Closing this one, and thanks for improving the guide.

@ankur-arch ankur-arch closed this Sep 16, 2026
ankur-arch added a commit that referenced this pull request Sep 16, 2026
@ankur-arch @claude
docs: apply community fixes that conflicted after the v6/v7 docs split (
9eb2d48 
#8283)

Re-applies five small community fixes on the current v6/v7 page paths.
The original PRs targeted paths that no longer exist on main.

- Cloudflare Workers: replace the removed `node_compat = true` (wrangler.toml)
  with the `nodejs_compat` compatibility flag in wrangler.jsonc (#8158, @liamiepops)
- GitHub Actions migrate example: `npm install` -> `npm ci` (#7924, @kanarian)
- Render deploy page: link the Blueprint setup guide (#7916, @Hephaest)
- TanStack Start guide: run `db:migrate`, not `db:seed`, to create tables,
  and move the seed step after generate (#7912, @tomdeabreucodes)
- TypeORM comparison: "Loosing" -> "Losing" (#7901, @monqyClouds)
- Community driver adapters: add prisma-sqlite-bun-adapter (#8129, @quinnjr)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@ankur-arch ankur-arch mentioned this pull request Sep 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TanStack Start guide contains errors in the setup command sequence

2 participants

@tomdeabreucodes @ankur-arch